Hard
Seqlock reader validating a snapshot with two sequence loads
This seqlock reader retries whenever s1 != s2, but never checks whether s1 itself is odd (i.e., a write was already in progress when the reader's first read of seq happened). Is while (s1 != s2) alone sufficient to guarantee the reader never returns torn data?
main.cpp
std::atomic<unsigned> seq{0};
Data data; // plain, non-atomic payload
void writer(const Data& d) {
seq.fetch_add(1, std::memory_order_release); // now odd: write in progress
data = d;
seq.fetch_add(1, std::memory_order_release); // now even: write complete
}
Data reader() {
Data local;
unsigned s1, s2;
do {
s1 = seq.load(std::memory_order_acquire);
local = data;
s2 = seq.load(std::memory_order_acquire);
} while (s1 != s2); // <-- missing: also must check !(s1 & 1)
return local;
}20 of 51 in Concurrency